Skip to content

Conversation

@dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Mar 10, 2025

Fixes: #448

Following changes:

  1. Make tests fail if importing connection class is failed
  2. Fix regression after 3ce7d7a
  3. Run pip upgrade in a separate step to avoid broken hash error

Fixes: #448

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Commit 3ce7d7a introduced regression
when instead of geven it is trying to import eventlet
@dkropachev dkropachev force-pushed the dk/fail-if-connection-class-is-not-available branch 2 times, most recently from 8d12a1a to 6414807 Compare March 10, 2025 21:51
@dkropachev dkropachev changed the title 1 Fix broken Is_gevent-money_patched Mar 10, 2025
@dkropachev dkropachev force-pushed the dk/fail-if-connection-class-is-not-available branch from 6414807 to e11202c Compare March 10, 2025 21:53
@dkropachev dkropachev requested a review from fee-mendes March 10, 2025 21:58
@dkropachev dkropachev changed the title Fix broken Is_gevent-money_patched Fix broken is_gevent-money_patched Mar 11, 2025
@dkropachev dkropachev force-pushed the dk/fail-if-connection-class-is-not-available branch from eadfbf5 to 8866d19 Compare March 11, 2025 02:20
@dkropachev dkropachev marked this pull request as ready for review March 11, 2025 02:20
@dkropachev dkropachev self-assigned this Mar 11, 2025
@dkropachev
Copy link
Collaborator Author

dkropachev commented Mar 11, 2025

@fee-mendes , fix works, unfortunately there is no way to add gevent and eventlet into the cicd, since integration suite getting stuck in a random places. Create separate issue to investigate and get them in.

@dkropachev dkropachev merged commit f910fc2 into scylladb:master Mar 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError 'eventlet' when importing cassandra.cluster after #443

2 participants